[WIP] Matmul infrastructure - #98
Merged
Merged
Conversation
The dense composition path formed term1 = 2w J_f^T Q J_f by filling a length-n all-2w vector every evaluation, purely because only the B^T diag(d) A dispatcher form was reachable. Use the new BTA_matrices_fill_values and carry the weight with one dscal on the result instead, mirroring term2. The diag_w field, its per-init allocation, and its free all go away. Also bump hess_term1's values_version after the direct ->x writes in both backends (the matrix.h contract for writers; previously only hess_term2 was bumped), and add a param-Q + nonlinear-child regression test: the refreshed Hessian must match a freshly built engine, both anchored against numerical differentiation. Verified load-bearing by mutation (dropping the dscal and staling QJf_dense both fail it). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HRnTPZsCXK6x2PSGUzanmg
dance858
force-pushed
the
matmul-infrastructure
branch
from
September 1, 2026 02:41
c15275b to
7354349
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm happy with this code, but should wrap it into quad form and add tests to python side before we merge it